manuel/foundryvtt-smart-doors
1
0
Fork 0
Code Issues 17 Pull Requests 2 Actions Packages Projects Releases 16 Wiki Activity

Door Outlines cause high GPU load #2

New Issue
Closed
opened 2021-01-28 03:32:13 +01:00 by rinnocenti · 4 comments
rinnocenti commented 2021-01-28 03:32:13 +01:00 (Migrated from github.com)
Copy Link

I don't know why but when activating the option to activate the outlines of the doors, the module consumes about 20% more of the GPU, the frame rate drops about 10% on weaker machines.

I don't know why but when activating the option to activate the outlines of the doors, the module consumes about 20% more of the GPU, the frame rate drops about 10% on weaker machines.
manuelVo commented 2021-01-28 14:06:16 +01:00 (Migrated from github.com)
Copy Link

The process of calculating the outlines more on the expensive side and the way it is now it is redone for each frame on each door. I didn't expect the calculation to be this expensive though. I'll see what I can do to improve the situation.

The process of calculating the outlines more on the expensive side and the way it is now it is redone for each frame on each door. I didn't expect the calculation to be this expensive though. I'll see what I can do to improve the situation.
manuelVo commented 2021-02-01 17:43:52 +01:00 (Migrated from github.com)
Copy Link

I've had an initial look at this and unfortunately it this seems to be a problem that is much harder to solve than I originally anticipated. I'll continue to think about how to improve the situation, but for the time being the only "soution" that I can offer is to disable the the outlines weaker machines.

I've had an initial look at this and unfortunately it this seems to be a problem that is much harder to solve than I originally anticipated. I'll continue to think about how to improve the situation, but for the time being the only "soution" that I can offer is to disable the the outlines weaker machines.
manuelVo commented 2021-02-11 22:57:18 +01:00 (Migrated from github.com)
Copy Link

I've had another look at this issue. Are you sure the slowdown is caused by high gpu load? I did some stress testing and on my machine the door outlines seemed to be more cpu limited than gpu limited. Unfortunately I don't have a slow machine that I could test this on.

I've had another look at this issue. Are you sure the slowdown is caused by high gpu load? I did some stress testing and on my machine the door outlines seemed to be more cpu limited than gpu limited. Unfortunately I don't have a slow machine that I could test this on.
manuelVo commented 2021-05-20 12:32:17 +02:00 (Migrated from github.com)
Copy Link

Door icons have an outline by default in Foundry 0.8. This means this feature has run it's course when that foundry version becomes stable and will be removed from Smart Doors. As a result I won't be pursuing improving the performance of it anymore.

Door icons have an outline by default in Foundry 0.8. This means this feature has run it's course when that foundry version becomes stable and will be removed from Smart Doors. As a result I won't be pursuing improving the performance of it anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 module conflict
The module conflicts with some other foundry module
 needs info
This ticket needs more information to be worked on
 question
Further information is requested
 wontfix
This will not be worked on
No Label enhancement needs info
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
manuel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: manuel/foundryvtt-smart-doors#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?