Feature request: Add prettier configuration to help development #25

New Issue

2022-05-02T12:58:54+02:00

p4535992 commented

2022-05-02 12:58:54 +02:00

(Migrated from github.com)

Hi I wanted to try to develop some new features for this module and as I was hoping to do a PR in the future it would be less "brutal" for both of us if you could provide your prettier configuration.
I ask because git makes me change a lot when instead I just changed things as spaces or simply added ';' at the end of the line.

This is the most common configuration used among foundryvtt developers, but choose the one you like best.

{
    "tabWidth": 2,
    "useTabs": false,
    "singleQuote": true,
    "trailingComma": "all",
    "semi": true,
    "printWidth": 120,
    "bracketSpacing": true
}

Hi I wanted to try to develop some new features for this module and as I was hoping to do a PR in the future it would be less "brutal" for both of us if you could provide your prettier configuration. I ask because git makes me change a lot when instead I just changed things as spaces or simply added ';' at the end of the line. This is the most common configuration used among foundryvtt developers, but choose the one you like best. ``` { "tabWidth": 2, "useTabs": false, "singleQuote": true, "trailingComma": "all", "semi": true, "printWidth": 120, "bracketSpacing": true } ```

manuelVo commented

2022-05-09 11:00:54 +02:00

(Migrated from github.com)

Hi there. I'm currently not using prettier at all to format my modules. If you'd like to open a PR, just make sure you follow the configuration given by the .editorconfig file (many editors do this automatically, if you have the editorconfig plugin installed). Apart from the few configurations given in there, feel free to format the code however you prefer. Just make sure the formatting isn't all over the place and don't touch lines you don't need to change for your PR, then it should be good :)

The format currently isn't exactly uniform, so you're better off not running prettier over the code at the moment, to avoid it modifying the whole repo.

Thanks in advance for whatever you have in stock!

Hi there. I'm currently not using prettier at all to format my modules. If you'd like to open a PR, just make sure you follow the configuration given by the `.editorconfig` file (many editors do this automatically, if you have the editorconfig plugin installed). Apart from the few configurations given in there, feel free to format the code however you prefer. Just make sure the formatting isn't all over the place and don't touch lines you don't need to change for your PR, then it should be good :) The format currently isn't exactly uniform, so you're better off not running prettier over the code at the moment, to avoid it modifying the whole repo. Thanks in advance for whatever you have in stock!

manuelVo commented

2022-05-09 11:03:25 +02:00

(Migrated from github.com)

I'll keep this issue open as a request to uniformly format the code and add a prettier configuration.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: manuel/foundryvtt-smart-doors#25