manuel/foundryvtt-socketlib
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't send a package id for commands as it's not needed

Browse Source
This commit is contained in:
Manuel Vögele
2021-04-26 17:29:57 +02:00
parent 971c92b21a
commit 1646bbbe3b
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -1,6 +1,7 @@
## In development ## In development
### New features ### New features
- The `this` value of functions now contains the id of the user that triggered the function execution. - The `this` value of functions now contains the id of the user that triggered the function execution.
- Some network packets are now more efficient.
### Bugfixes ### Bugfixes
- When an invalid user id is specified socketlib will now throw the correct error message. - When an invalid user id is specified socketlib will now throw the correct error message.

4
src/socketlib.js
View File

@@ -168,7 +168,6 @@ class SocketlibSocket {
_sendCommand(handlerName, args, recipient) { _sendCommand(handlerName, args, recipient) {
const message = {handlerName, args, recipient}; const message = {handlerName, args, recipient};
message.id = randomID();
message.type = MESSAGE_TYPES.COMMAND; message.type = MESSAGE_TYPES.COMMAND;
game.socket.emit(this.socketName, message); game.socket.emit(this.socketName, message);
} }
@@ -241,7 +240,7 @@ class SocketlibSocket {
[name, func] = this._resolveFunction(handlerName); [name, func] = this._resolveFunction(handlerName);
} }
catch (e) { catch (e) {
if (e instanceof errors.SocketlibUnregisteredHandlerError) { if (e instanceof errors.SocketlibUnregisteredHandlerError && type === MESSAGE_TYPES.REQUEST) {
this._sendError(id, MESSAGE_TYPES.UNREGISTERED); this._sendError(id, MESSAGE_TYPES.UNREGISTERED);
} }
throw e; throw e;
@@ -258,7 +257,6 @@ class SocketlibSocket {
} }
catch (e) { catch (e) {
console.error(`An exception occured while executing handler '${name}'.`); console.error(`An exception occured while executing handler '${name}'.`);
this._sendError(id, MESSAGE_TYPES.EXCEPTION);
throw e; throw e;
} }
this._sendResult(id, result); this._sendResult(id, result);